[PATCH] D70167: Fix use of add_llvm_tool in projects that build no targets

[Kévin Petit via Phabricator via llvm-commits]

kpet created this revision.
kpet added a reviewer: svenvh.
Herald added subscribers: llvm-commits, kristof.beyls, mgorny.
Herald added a project: LLVM.

Projects that set LLVM_TARGETS_TO_BUILD to an empty list
can't use add_llvm_tool (and probably other macros).

Here's the error that this change fixes:

list sub-command REMOVE_ITEM requires two or more arguments.

Signed-off-by: Kevin Petit <kevin.petit at arm.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70167

Files:
  llvm/cmake/modules/LLVM-Config.cmake


Index: llvm/cmake/modules/LLVM-Config.cmake
===================================================================
--- llvm/cmake/modules/LLVM-Config.cmake
+++ llvm/cmake/modules/LLVM-Config.cmake
@@ -28,7 +28,7 @@
     string(TOUPPER "${LLVM_TARGETS_TO_BUILD}" targets)
   elseif(ARG_OMITTED_TARGETS)
     set(omitted_targets ${LLVM_ALL_TARGETS})
-    list(REMOVE_ITEM omitted_targets ${LLVM_TARGETS_TO_BUILD})
+    list(REMOVE_ITEM omitted_targets "${LLVM_TARGETS_TO_BUILD}")
     string(TOUPPER "${omitted_targets}" targets)
   else()
     string(TOUPPER "${LLVM_ALL_TARGETS}" targets)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70167.229027.patch
Type: text/x-patch
Size: 586 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191113/77bfc7e5/attachment.bin>