[PATCH] D70020: [lld] Better support for group semantic wrt. notes

[serge via Phabricator via llvm-commits]

serge-sans-paille added a comment.

Thanks for the alternative patch! Indeed using a new field avoids interacting with `dependentSections` and makes it possible to cleanly match ld's behavior.

I'm surprised by ld's behavior wrt.  discarding a group member. Based on the semantic of a group, I would have assumed that it either raises an error, or discards the whole group, or raise a warning and keep the section if the whole group is not discarded. Allowing to remove a section from the group seems strange to me. Quoting https://docs.oracle.com/cd/E23824_01/html/819-0690/chapter7-26.html

> However, these references make no sense if one of the sections were removed

I'll try to find more info on that aspect.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70020/new/

https://reviews.llvm.org/D70020