[PATCH] D70107: [VFABI] TargetLibraryInfo mappings in IR.

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli marked 5 inline comments as done.
fpetrogalli added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/InjectTLIMappings.h:19
+namespace llvm {
+class InjectTLIMappingsPass : public PassInfoMixin<InjectTLIMappingsPass> {
+  const TargetLibraryInfo &TLI;
----------------
andwar wrote:
> sdesmalen wrote:
> > Don't forget about the old pass manager :)
> `Legacy` :)
> 
> Also, I am not a fan of appending `Pass` to pass classes (it's clear what this class inherits from either way). Also, if you use `INITIALIZE_PASS_BEGIN`, `Pass` is going to be  prepended to the _Initialize_ method anyway (so you will have `initializeInjestTLIMappingPassPass`): https://github.com/llvm/llvm-project/blob/848007cfbc7509543c5b8604ae063bb6c8ffa0a9/llvm/include/llvm/PassSupport.h#L62
I am working on it! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70107/new/

https://reviews.llvm.org/D70107