[PATCH] D68857: [X86] Add strict fp support for operations of X87 instructions

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 12 19:44:17 PST 2019


craig.topper added a comment.

I think we need to re-evaluate our testing strategy here. These tests pass on trunk without any of the other changes.

I was going to suggest adding -stop-after=finalize-isel so we could check the fpexcept bit, but the mutating code preserves the fpexcept bit from the strict fp node we mutated. So I'm not sure how we can tell that this patch works correctly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68857/new/

https://reviews.llvm.org/D68857





More information about the llvm-commits mailing list