[PATCH] D70161: [cmake] Emit an error for -DBUILD_SHARED_LIBS=ON on Windows

[Tom Stellard via Phabricator via llvm-commits]

tstellar created this revision.
tstellar added reviewers: beanz, smeenai, compnerd, phosek.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.

The BUILD_SHARED_LIBS=ON build fails on Windows, so prevent users from
enabling it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70161

Files:
  llvm/CMakeLists.txt


Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -570,6 +570,9 @@
   # Set this variable to OFF here so it can't be set with a command-line
   # argument.
   set (LLVM_LINK_LLVM_DYLIB OFF)
+  if (BUILD_SHARED_LIBS)
+    message(FATAL_ERROR "BUILD_SHARED_LIBS options is not supported on Windows.")
+  endif()
 else()
   option(LLVM_LINK_LLVM_DYLIB "Link tools against the libllvm dynamic library" OFF)
   option(LLVM_BUILD_LLVM_C_DYLIB "Build libllvm-c re-export library (Darwin only)" OFF)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70161.229002.patch
Type: text/x-patch
Size: 588 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191113/a10046e5/attachment.bin>