[PATCH] D70159: [cmake] Remove confusing condition argument from else() NFC

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 12 19:35:05 PST 2019


tstellar created this revision.
tstellar added reviewers: dsanders, beanz, smeenai, compnerd, phosek.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.

This makes it look like an elseif and also the variable referenced
in the condition was removed from this function in r366622.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70159

Files:
  llvm/cmake/modules/LLVM-Config.cmake


Index: llvm/cmake/modules/LLVM-Config.cmake
===================================================================
--- llvm/cmake/modules/LLVM-Config.cmake
+++ llvm/cmake/modules/LLVM-Config.cmake
@@ -268,7 +268,7 @@
       # already processed
     elseif( c STREQUAL "all" )
       list(APPEND expanded_components ${LLVM_AVAILABLE_LIBS})
-    else( NOT idx LESS 0 )
+    else()
       # Canonize the component name:
       string(TOUPPER "${c}" capitalized)
       list(FIND capitalized_libs LLVM${capitalized} lib_idx)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70159.229000.patch
Type: text/x-patch
Size: 518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191113/c8745e03/attachment.bin>


More information about the llvm-commits mailing list