[PATCH] D70147: Repeat DevirtSCCRepeatedPass if any inlining happens.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 12 14:50:02 PST 2019


yamauchi created this revision.
yamauchi added a reviewer: davidxl.
Herald added subscribers: hiraditya, eraman, Prazek, mehdi_amini.
Herald added a project: LLVM.

This aims to fix a missed inlining case.

If there's a virtual call in the callee on an alloca (stack allocated object) in
the caller, and the callee is inlined into the caller, the post-inline cleanup
would devirtualize the virtual call, but if the next iteration of
DevirtSCCRepeatedPass doesn't happen (under the new pass manager), which is
based on a heuristic to determine whether to reiterate, we may miss inlining the
devirtualized call.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70147

Files:
  llvm/include/llvm/Analysis/CGSCCPassManager.h
  llvm/lib/Transforms/IPO/Inliner.cpp
  llvm/test/Transforms/Inline/devirtualize-4.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70147.228968.patch
Type: text/x-patch
Size: 8192 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191112/229d385f/attachment.bin>


More information about the llvm-commits mailing list