[PATCH] D70112: [llvm-readobj] - Improve dumping of the SHT_LLVM_LINKER_OPTIONS sections.
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 12 14:21:45 PST 2019
compnerd added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6020
- ArrayRef<uint8_t> Contents =
+ ArrayRef<uint8_t> Content =
unwrapOrError(this->FileName, Obj->getSectionContents(&Shdr));
----------------
`Contents` is the correct word for this.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6029
+ FileName);
+ return;
+ }
----------------
This should probably be a `continue`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70112/new/
https://reviews.llvm.org/D70112
More information about the llvm-commits
mailing list