[PATCH] D69740: [profile] Support counter relocation at runtime

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 12 10:28:12 PST 2019


vsk added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingFile.c:235
+  /* Get the size of the profile on disk. */
+  if (getProfileFileSizeForMerging(ProfileFile, &ProfileFileSize) == -1)
+    return -1;
----------------
davidxl wrote:
> Can you split the refactoring change into a separate patch to minimize diff here?
I believe this code is borrowed from D69586. I'll split the refactoring bits out from that review and start a fresh one: D70135


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69740/new/

https://reviews.llvm.org/D69740





More information about the llvm-commits mailing list