[PATCH] D70036: [llvm-objcopy][COFF] Implement --redefine-sym and --redefine-syms

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp:138
+      Sym.Name = I->getValue();
+  }
+
----------------
mstorsjo wrote:
> One pretty relevant functional aspect of this, is the fact that a request to rename a symbol that doesn't exist passes through silently (which I presume matches GNU behaviour). It might be good to add a test of that aspect.
A non-existent symbol does not error. Added a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70036/new/

https://reviews.llvm.org/D70036