[PATCH] D69281: [FPEnv][WIP] Constrained FCmp intrinsics

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:1420
+    OpChains.push_back(ScalarChain);
   }
 
----------------
This throws away strict-ness for the expanded scalar selects. Is that deliberate?

I would have expected this to produce scalar STRICT_FSETCC nodes instead.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:3832
+    return N->getOperand(0).getValueType();
+}
+
----------------
This else can be removed.


================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.cpp:2514
     C.CCValid = SystemZ::CCMASK_FCMP;
-    C.Opcode = SystemZISD::FCMP;
+    C.Opcode = C.Chain? SystemZISD::STRICT_FCMP : SystemZISD::FCMP;
     adjustForFNeg(C);
----------------
Missing space before `?`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69281/new/

https://reviews.llvm.org/D69281