[PATCH] D70105: [lit] Better/earlier errors for empty runs

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.





================
Comment at: llvm/utils/lit/lit/cl_arguments.py:8
 
+# TODO(yln): scan dest, to see if is redundant
 def parse_args():
----------------
Is this comment relevant to this patch?


================
Comment at: llvm/utils/lit/lit/main.py:71
+            sys.stderr.write('Filter did not match any tests '
+                             '(of %d discovered).\n' % numTotalTests)
+            code = 0 if opts.allow_empty_runs else 2
----------------
When `--allow-empty-runs` is not already specified, could we have this diagnostic suggest it?  Otherwise, could we have it report that it was specified?


================
Comment at: llvm/utils/lit/lit/run.py:48
         """
-        if not self.tests:
-            return 0.0
----------------
Would it be wortwhile to turn this guard into an assert rather than just removing it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70105/new/

https://reviews.llvm.org/D70105