[PATCH] D69275: Add constrained int->FP intrinsics

[Kevin P. Neal via Phabricator via llvm-commits]

kpn marked an inline comment as done.
kpn added a comment.

I like the switch to using update_llc_test_checks.py. Sure, I'll rebase, run that script and it'll be in the next round of this patch when I can.



================
Comment at: llvm/test/CodeGen/X86/fp-intrinsics.ll:530
+; NO-FMA:         cvtsi2ss
+; NO-FMA:         cvtsi2ss
+;
----------------
andrew.w.kaylor wrote:
> Some more context would be useful here. I believe there is a test a jump and an addss that are also relevant in the output.
These issues are solved by switching to using the update_llc_test_checks.py script that Craig ran. I'll have it in my next round of this patch when I can get to it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69275/new/

https://reviews.llvm.org/D69275