[PATCH] D70116: [RISCV] add subtargets initialized with target feature

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 12 03:53:03 PST 2019


lenary added a reviewer: efriedma.
lenary added a subscriber: efriedma.
lenary added a comment.

Nice, if this is the correct way to do it, then it's looking good.

I see x86 and arm both inspect the "soft-float" attribute, which seems to come from the `-msoft-float` clang option. Should RISC-V be using that to switch off the `d` and `f` target features?

I'm going to add @efriedma to the reviewers, as he flagged up this was implemented in the wrong way before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70116/new/

https://reviews.llvm.org/D70116





More information about the llvm-commits mailing list