[PATCH] D70113: Mark llvm::ConstantExpr::getAsInstruction as const

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 12 05:32:50 PST 2019


jmolloy added a comment.

Hi Alex,

Thanks. That's fair, and because this is the only member that wasn't const-correct I approved this change. But bear in mind in general that LLVM is not intended to be const-correct by design. More invasive patches may get more pushback.

Cheers,

James


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70113/new/

https://reviews.llvm.org/D70113





More information about the llvm-commits mailing list