[PATCH] D70115: DWARFDebugLoclists: stricter base address handling

[Pavel Labath via Phabricator via llvm-commits]

labath created this revision.
labath added reviewers: dblaikie, probinson, JDevlieghere, aprantl, SouraVX.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
labath added a parent revision: D70084: DWARFDebugLoclists: Add an api to get the location lists of a DWARF unit.

This removes the use of zero as a base address in section-based dumping.
Although this will often be true for (unlinked) object files with a
single compile unit, it is not true in general. This means that
section-based dumping will not be able to resolve entries referencing
the base address (DW_LLE_offset_pair) -- it wasn't able to do that
correctly before either, but now it will be more explicit about it. One
exception to that is if the location list contains an explicit
DW_LLE_base_address entry -- in this case the dumper will pick it up,
and resolve subsequent entries normally.

The patch also removes the fallback to zero in the "inline" dumping in
case the compile unit does not contain a base address.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70115

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
  llvm/test/DebugInfo/X86/dwarfdump-debug-loclists.test
  llvm/test/tools/llvm-dwarfdump/X86/debug_loclists.s
  llvm/test/tools/llvm-dwarfdump/X86/debug_loclists_multiple.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70115.228839.patch
Type: text/x-patch
Size: 8854 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191112/079d467b/attachment.bin>