[PATCH] D70114: AMDGPU: Extend add x, (ext setcc) combine to sub

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

AFAIR this was there with the first version of the combine, but then triggered bugs. Please run PSDB before going forward. It should work but exposed problems previously.



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:9594
+    auto Cond = RHS.getOperand(0);
+    if (!isBoolSGPR(Cond))
+      break;
----------------
What's the point of this check? Performance or correctness? It needs a comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70114/new/

https://reviews.llvm.org/D70114