[PATCH] D70107: [VFABI] TargetLibraryInfo mappings in IR.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

@fpetrogalli This means that all passes that need to care about vector variants of functions need to add a dependency on this pass, right? This seems quite similar to how TBAA info is loaded from IR metadata using an analysis pass, after which the information can be queried using the AliasAnalysis interfaces. This is doing a similar thing, but then for querying vector-variants of functions, so +1 for the approach!

We should not forget to document the new mechanism (the VFABI, metadata attributes and the SVFS mechanism), perhaps as a separate document. The metadata format should at least be described in the LangRef.



================
Comment at: llvm/include/llvm/Transforms/Utils/InjectTLIMappings.h:19
+namespace llvm {
+class InjectTLIMappingsPass : public PassInfoMixin<InjectTLIMappingsPass> {
+  const TargetLibraryInfo &TLI;
----------------
Don't forget about the old pass manager :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70107/new/

https://reviews.llvm.org/D70107