[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 11 13:16:40 PST 2019
ABataev added inline comments.
================
Comment at: llvm/include/llvm/IR/OpenMPConstants.h:57
+#include "llvm/IR/OpenMPKinds.def"
+ LLVM_MARK_AS_BITMASK_ENUM(0x7FFFFFFF)
+};
----------------
Why do you use `0x7FFFFFFF` as the largest value?
================
Comment at: llvm/lib/IR/OpenMPIRBuilder.cpp:49-51
+ default:
+ // Attributes are optional.
+ break;
----------------
Do you need the `default:` here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69785/new/
https://reviews.llvm.org/D69785
More information about the llvm-commits
mailing list