[PATCH] D69411: [MC] Parse .if conditions with symbols in consecutive MCDataFragements

[Jian Cai via Phabricator via llvm-commits]

jcai19 marked an inline comment as done.
jcai19 added inline comments.


================
Comment at: llvm/test/MC/AsmParser/directive_if_offset.s:5
+nop
+.arch_extension sec
+9997: nop ;
----------------
peter.smith wrote:
> Is this line significant for the test? If it isn't then it is worth taking it out.
This line is required to reproduce this issue, as  it changes the subtarget and forces the creation of a new  MCDataSegment (https://llvm.org/doxygen/MCObjectStreamer_8cpp_source.html#l00157). I found a similar directive for i386, .arch + cpu_type (https://sourceware.org/binutils/docs/as/i386_002dArch.html#i386_002dArch), although the parser does not support it. To have a similar test case on x86, it seems we would have to first support that directive. However, I could not find any uses of this directive in llvm or Linux kernel, so I assume it is not commonly used. Will keep the test case for arm for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69411/new/

https://reviews.llvm.org/D69411