[PATCH] D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:887
+  /// return the limit for functions that have OptSize attribute.
+  unsigned getMaxStoresPerMemset(bool OptSize) const;
+
----------------
Needs an address space


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:895
+  /// return the limit for functions that have OptSize attribute.
+  unsigned getMaxStoresPerMemcpy(bool OptSize) const;
+
----------------
Needs source and dest address spaces. The alignment is also a consideration


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:899-901
+  /// This function returns the maximum number of store operations permitted
+  /// to glue together during lowering of llvm.memcpy. The value is set by
+  //  the target at the performance threshold for such a replacement.
----------------
I don't understand what I means by glue here. Like SelectionDAG glue? I don't think this is a useful concept to expose to the IR


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70108/new/

https://reviews.llvm.org/D70108