[PATCH] D70049: [CodeMoverUtils] Added an API to check if an instruction can be safely moved before another instruction.

[Whitney Tsang via Phabricator via llvm-commits]

Whitney added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/CodeMoverUtils.h:29-31
+bool IsControlFlowEquivalent(const Instruction &I0, const Instruction &I1,
+                             const DominatorTree &DT,
+                             const PostDominatorTree &PDT);
----------------
Meinersbur wrote:
> Whitney wrote:
> > Meinersbur wrote:
> > > [style] Start function names with lower case letters.
> > Actually I intensionally start with upper case for this function, as I see global functions in other files also start with upper case (e.g. CloneFunction.cpp). Do you know which way is the recommenced style?
> Functions with starting capital letter is an older style. It's just that nobody put in the work to do the style conversion yet. 
> 
> Recently, the community was even discussing applying lower camelCase to variables as well and apply it wholesale with a conversion script.
> 
> In any case, PascalCase style for functions is deprecated and I see no reason why no going to the current coding convention.
Good to know! I thought there is a different convention for different kind of functions.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70049/new/

https://reviews.llvm.org/D70049