[PATCH] D70026: [cmake] Always build the libLLVM shared library

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: llvm/CMakeLists.txt:573-577
+  set(LLVM_BUILD_LLVM_DYLIB OFF)
 else()
   option(LLVM_LINK_LLVM_DYLIB "Link tools against the libllvm dynamic library" OFF)
   option(LLVM_BUILD_LLVM_C_DYLIB "Build libllvm-c re-export library (Darwin only)" OFF)
+  set(LLVM_BUILD_LLVM_DYLIB ON)
----------------
tstellar wrote:
> @beanz Does setting the variables here override the cache variables?
Yup, setting the variable here will override the cached value. Any reason to prefer this to just removing all uses of the variable though?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70026/new/

https://reviews.llvm.org/D70026