[llvm] 70193b2 - [NFC] Fix test case after edab7dd426249bd40059b49b255ba9cc5b784753

Nemanja Ivanovic via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 11 18:41:00 PST 2019


Author: Nemanja Ivanovic
Date: 2019-11-11T20:40:40-06:00
New Revision: 70193b21d18ba0e4f9b9f68918c71bd91a887246

URL: https://github.com/llvm/llvm-project/commit/70193b21d18ba0e4f9b9f68918c71bd91a887246
DIFF: https://github.com/llvm/llvm-project/commit/70193b21d18ba0e4f9b9f68918c71bd91a887246.diff

LOG: [NFC] Fix test case after edab7dd426249bd40059b49b255ba9cc5b784753

The author of the patch forgot to add -verify-machineinstrs to the RUN
lines which would have made the issue appear on all bots. Added that
as well as a fix for the undefined register issue (after the hoisting).

Added: 
    

Modified: 
    llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessNoProfileData.mir
    llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessProfileData.mir

Removed: 
    


################################################################################
diff  --git a/llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessNoProfileData.mir b/llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessNoProfileData.mir
index 3100d07311b7..c529b91cdd0d 100644
--- a/llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessNoProfileData.mir
+++ b/llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessNoProfileData.mir
@@ -1,8 +1,21 @@
-# NOTE: This test verifies disable/enable instruction hoisting to hot blocks based on non-profile data
-# RUN: llc -run-pass early-machinelicm -mtriple=powerpc64le-unknown-linux-gnu -disable-hoisting-to-hotter-blocks=all -block-freq-ratio-threshold=100 %s -o - | FileCheck %s --check-prefix=CHECK-NO-HOIST
-# RUN: llc -run-pass early-machinelicm -mtriple=powerpc64le-unknown-linux-gnu -disable-hoisting-to-hotter-blocks=all -block-freq-ratio-threshold=100000000 %s -o - | FileCheck %s --check-prefix=CHECK-HOIST
-# RUN: llc -run-pass early-machinelicm -mtriple=powerpc64le-unknown-linux-gnu -disable-hoisting-to-hotter-blocks=pgo -block-freq-ratio-threshold=100 %s -o - | FileCheck %s --check-prefix=CHECK-HOIST
-# RUN: llc -run-pass early-machinelicm -mtriple=powerpc64le-unknown-linux-gnu -disable-hoisting-to-hotter-blocks=none -block-freq-ratio-threshold=100 %s -o - | FileCheck %s --check-prefix=CHECK-HOIST
+# NOTE: This test verifies disable/enable instruction hoisting to hot blocks
+#       based on non-profile data
+# RUN: llc -run-pass early-machinelicm -mtriple=powerpc64le-unknown-linux-gnu \
+# RUN:   -verify-machineinstrs -disable-hoisting-to-hotter-blocks=all \
+# RUN:   -block-freq-ratio-threshold=100 %s -o - | FileCheck %s \
+# RUN:   --check-prefix=CHECK-NO-HOIST
+# RUN: llc -run-pass early-machinelicm -mtriple=powerpc64le-unknown-linux-gnu \
+# RUN:   -verify-machineinstrs -disable-hoisting-to-hotter-blocks=all \
+# RUN:   -block-freq-ratio-threshold=100000000 %s -o - | FileCheck %s \
+# RUN:   --check-prefix=CHECK-HOIST
+# RUN: llc -run-pass early-machinelicm -mtriple=powerpc64le-unknown-linux-gnu \
+# RUN:   -verify-machineinstrs -disable-hoisting-to-hotter-blocks=pgo \
+# RUN:   -block-freq-ratio-threshold=100 %s -o - | FileCheck %s \
+# RUN:   --check-prefix=CHECK-HOIST
+# RUN: llc -run-pass early-machinelicm -mtriple=powerpc64le-unknown-linux-gnu \
+# RUN:   -verify-machineinstrs -disable-hoisting-to-hotter-blocks=none \
+# RUN:   -block-freq-ratio-threshold=100 %s -o - | FileCheck %s \
+# RUN:   --check-prefix=CHECK-HOIST
 
 --- |
   target datalayout = "e-m:e-i64:64-n32:64"
@@ -119,6 +132,7 @@ body:             |
   bb.1.for.body.lr.ph:
     successors: %bb.3(0x80000000)
 
+    INLINEASM &"#NOTHING", 1, 12, implicit-def early-clobber $r2
     %11:crrc = CMPWI %7, 10
     %0:crbitrc = COPY %11.sub_gt
     %10:gprc = LI 0

diff  --git a/llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessProfileData.mir b/llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessProfileData.mir
index 3cf87396e8bf..d1530099cf8e 100644
--- a/llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessProfileData.mir
+++ b/llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessProfileData.mir
@@ -1,7 +1,20 @@
-# NOTE: This test verifies disable/enable instruction hoisting to hot blocks based on profile data
-# RUN: llc -run-pass early-machinelicm -mtriple=powerpc64le-unknown-linux-gnu -disable-hoisting-to-hotter-blocks=pgo -block-freq-ratio-threshold=100 %s -o - | FileCheck %s --check-prefix=CHECK-NO-HOIST
-# RUN: llc -run-pass early-machinelicm -mtriple=powerpc64le-unknown-linux-gnu -disable-hoisting-to-hotter-blocks=pgo -block-freq-ratio-threshold=100000000 %s -o - | FileCheck %s --check-prefix=CHECK-HOIST
-# RUN: llc -run-pass early-machinelicm -mtriple=powerpc64le-unknown-linux-gnu -disable-hoisting-to-hotter-blocks=none -block-freq-ratio-threshold=100 %s -o - | FileCheck %s --check-prefix=CHECK-HOIST
+# NOTE: This test verifies disable/enable instruction hoisting to hot blocks
+#       based on profile data
+# RUN: llc -run-pass early-machinelicm -verify-machineinstrs \
+# RUN:   -mtriple=powerpc64le-unknown-linux-gnu \
+# RUN:   -disable-hoisting-to-hotter-blocks=pgo \
+# RUN:   -block-freq-ratio-threshold=100 %s -o - | FileCheck %s \
+# RUN:   --check-prefix=CHECK-NO-HOIST
+# RUN: llc -run-pass early-machinelicm -verify-machineinstrs \
+# RUN:   -mtriple=powerpc64le-unknown-linux-gnu \
+# RUN:   -disable-hoisting-to-hotter-blocks=pgo \
+# RUN:   -block-freq-ratio-threshold=100000000 %s -o - | FileCheck %s \
+# RUN:   --check-prefix=CHECK-HOIST
+# RUN: llc -run-pass early-machinelicm -verify-machineinstrs \
+# RUN:   -mtriple=powerpc64le-unknown-linux-gnu \
+# RUN:   -disable-hoisting-to-hotter-blocks=none \
+# RUN:   -block-freq-ratio-threshold=100 %s -o - | FileCheck %s \
+# RUN:   --check-prefix=CHECK-HOIST
 
 --- |
   target datalayout = "e-m:e-i64:64-n32:64"
@@ -165,6 +178,7 @@ body:             |
   bb.1.for.body.lr.ph:
     successors: %bb.3(0x80000000)
 
+    INLINEASM &"#NOTHING", 1, 12, implicit-def early-clobber $r2, !31
     %11:crrc = CMPWI %7, 10
     %0:crbitrc = COPY %11.sub_gt
     %10:gprc = LI 0


        


More information about the llvm-commits mailing list