[PATCH] D69932: [IR] Redefine Freeze instruction

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 11 14:29:06 PST 2019


lebedev.ri added a comment.

In D69932#1741378 <https://reviews.llvm.org/D69932#1741378>, @craig.topper wrote:

> In D69932#1740114 <https://reviews.llvm.org/D69932#1740114>, @lebedev.ri wrote:
>
> > Thanks! Sorry for double work..
> >
> > I guess in principle this has backwards compatibility issues,
> >  since `bitc::UNOP_FREEZE` goes away? But since LLVM itself
> >  never produced them until this moment, do we care?
> >
> > Other than that this looks good to me.
> >  Anyone else?
>
>
> I don't think we have a backwards compatibility guarantee on trunk. Only across release boundaries. So I think this should be fine.


Hm, good to know, thanks!

> LGTM




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69932/new/

https://reviews.llvm.org/D69932





More information about the llvm-commits mailing list