[PATCH] D69546: [SanitizerCommon] Print the current value of options when printing out help.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 11 13:25:41 PST 2019


delcypher marked an inline comment as done.
delcypher added inline comments.


================
Comment at: compiler-rt/lib/msan/msan.cpp:126
+  bool Format(char *buffer, uptr size) final {
+    const char *keep_going_str = (*halt_on_error) ? "false" : "true";
+    uptr keep_going_str_len = internal_strlcpy(buffer, keep_going_str, size);
----------------
yln wrote:
> Does this compile? `halt_on_error` seems to be missing `_`.
Good catch. MSan doesn't build on darwin so I missed this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69546/new/

https://reviews.llvm.org/D69546





More information about the llvm-commits mailing list