[PATCH] D70096: [strictfp] Replace dangling strictfp attrs with nobuiltin
Kevin P. Neal via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 11 12:12:07 PST 2019
kpn added a comment.
Do we want to restrict this so it doesn't get upgraded if found in a future bitcode version?
Do we want to not upgrade if a constrained intrinsic is used anywhere in the function? We do want to be able to distinguish between pre-constrained intrinsic uses and modern constrained uses that are wrong. I am assuming that the upgrade happens before the IR verifier runs.
================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:2965
// Look for intrinsic functions which need to be upgraded at some point
+ // and function that need to have their function attributes upgraded.
for (Function &F : *TheModule) {
----------------
typo: s/function/functions/
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70096/new/
https://reviews.llvm.org/D70096
More information about the llvm-commits
mailing list