[PATCH] D69275: Add constrained int->FP intrinsics

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 11 10:59:07 PST 2019


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1248
 
+        if (Node->isStrictFPOpcode() && !Res.getNode()->isStrictFPOpcode()) {
+          LLVM_DEBUG(dbgs() << "Successfully custom legalized strict node\n");
----------------
Should we just be returning MERGE_VALUES from the custom handler for the strict fp nodes? That's how we handle loads and atomics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69275/new/

https://reviews.llvm.org/D69275





More information about the llvm-commits mailing list