[PATCH] D68779: [LNT][NFC] Fix global import in function
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 11 10:31:45 PST 2019
thopre added a comment.
In D68779#1741055 <https://reviews.llvm.org/D68779#1741055>, @cmatthews wrote:
> I don't understand why we are not using normal import at the top level here?
According to a comment in the file it's done this way to load dependencies lazily. It does not say why it is desirable to do so though. Since the same dependencies are loaded for all admin subcommand I'd say it's probably not necessary but I'd prefer to fix that in a separate patch once all Python 3 support patches are in to keep this one a NFC.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68779/new/
https://reviews.llvm.org/D68779
More information about the llvm-commits
mailing list