[PATCH] D70080: [AArch64][SVE] Allocate locals that are scalable vectors.
Cameron McInally via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 11 08:22:14 PST 2019
cameron.mcinally added a comment.
LGTM. Will give other reviewers some time to review though...
================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:2556
- // Note: We don't take allocatable stack objects into
- // account yet, because allocation for those is not yet
- // implemented.
+ // Create a buffer of SVE objects to allocate and sort it.
+ SmallVector<int, 8> ObjectsToAllocate;
----------------
Nit: It doesn't actually sort them, right? Or did I miss it? I'm assuming that we'll want to eventually order SVE stack objects by size.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70080/new/
https://reviews.llvm.org/D70080
More information about the llvm-commits
mailing list