[PATCH] D69898: [Mips] Add rematerialization support for ldi.fmt

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added a comment.

As far as I understand the code, overriding `isReallyTriviallyReMaterializable` and `reMaterialize` is not mandatory to avoid spill for `ldi.fmt`. Let's split the patch. The first patch could adds `isReMaterializable` flag to the `MSA_I10_LDI_DESC_BASE` and test the change. The second one - overrides `isReallyTriviallyReMaterializable` and `reMaterialize`. By the way, what is a goal of overriding `reMaterialize`? Does it give any benefit?



================
Comment at: llvm/test/CodeGen/Mips/msa/remat-ldi.ll:109
+
+!llvm.module.flags = !{!0}
+!0 = !{i32 1, !"wchar_size", i32 4}
----------------
These lines can be removed from the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69898/new/

https://reviews.llvm.org/D69898