[PATCH] D70068: [SLP] Enhance SLPVectorizer to vectorize vector aggregate

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/pr42022.ll:4
+
+%struct.Vector4 = type { float, float, float, float }
+
----------------
ABataev wrote:
> anton-afanasyev wrote:
> > RKSimon wrote:
> > > Regenerate with update_test_checks.py ?
> > Should it really be autogenerated? I don't like test autogeneration for excessiveness and false positives while testing. Here we just checking vector `<4 x float>` is generated. Is autogeneration really standard for tests now?
> It is common practice to use auto checks and demonstrate the difference then.
update_test_checks.py helps us identify any hidden regressions

also you can probably remove the dso_local and local_unnamed_addr #0 tags


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70068/new/

https://reviews.llvm.org/D70068