[PATCH] D70079: [SelectionDAG] Combine U{ADD,SUB}O diamonds into {ADD,SUB}CARRY

[David Zarzycki via Phabricator via llvm-commits]

davezarzycki added a comment.

With all the targets enabled, only System Z fails. It looks like somebody just needs to update the assembly.

  FAIL: LLVM :: CodeGen/SystemZ/int-uadd-03.ll (15196 of 34316)
  ******************** TEST 'LLVM :: CodeGen/SystemZ/int-uadd-03.ll' FAILED ********************
  Script:
  --
  : 'RUN: at line 3';   /home/dave/b/l/t/bin/llc < /home/dave/s/l/llvm/test/CodeGen/SystemZ/int-uadd-03.ll -mtriple=s390x-linux-gnu | /home/dave/b/l/t/bin/FileCheck /home/dave/s/l/llvm/test/CodeGen/SystemZ/int-uadd-03.ll
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/dave/s/l/llvm/test/CodeGen/SystemZ/int-uadd-03.ll:202:10: error: CHECK: expected string not found in input
  ; CHECK: algf %r2, 160(%r15)
           ^
  <stdin>:207:2: note: scanning from here
   llgfr %r1, %r13
   ^
  <stdin>:239:2: note: possible intended match here
   algf %r1, 160(%r15) # 4-byte Folded Reload
   ^
  
  --
  
  ********************
  FAIL: LLVM :: CodeGen/SystemZ/int-usub-03.ll (15237 of 34316)
  ******************** TEST 'LLVM :: CodeGen/SystemZ/int-usub-03.ll' FAILED ********************
  Script:
  --
  : 'RUN: at line 3';   /home/dave/b/l/t/bin/llc < /home/dave/s/l/llvm/test/CodeGen/SystemZ/int-usub-03.ll -mtriple=s390x-linux-gnu | /home/dave/b/l/t/bin/FileCheck /home/dave/s/l/llvm/test/CodeGen/SystemZ/int-usub-03.ll
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/dave/s/l/llvm/test/CodeGen/SystemZ/int-usub-03.ll:210:10: error: CHECK: expected string not found in input
  ; CHECK: slgf %r2, 160(%r15)
           ^
  <stdin>:215:2: note: scanning from here
   lgr %r3, %r2
   ^
  <stdin>:251:2: note: possible intended match here
   slgf %r1, 160(%r15) # 4-byte Folded Reload
   ^
  
  --
  
  ********************
  
  Testing Time: 34.33s
  ********************
  Failing Tests (2):
      LLVM :: CodeGen/SystemZ/int-uadd-03.ll
      LLVM :: CodeGen/SystemZ/int-usub-03.ll
  
    Expected Passes    : 33723
    Expected Failures  : 150
    Unsupported Tests  : 441
    Unexpected Failures: 2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70079/new/

https://reviews.llvm.org/D70079