[PATCH] D69461: [XRay] Sanitize DOT labels in graph output

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 10 15:02:22 PST 2019


dberris accepted this revision.
dberris added a comment.

In D69461#1739991 <https://reviews.llvm.org/D69461#1739991>, @tetsuo-cpp wrote:

> I compiled multiple older versions of `dot` and gave them a try (I went back to `2.30.1`) but still didn't see this problem. I've been testing like this (mainly testing SVG and JSON):
>
>   tetsuo at garland-1572667608860-c-16-sgp1-01:~/dev/llvm-project$ build/bin/llvm-xray graph ./xray-log.a.out.uRHPKt -instr_map ./a.out | dot -Tsvg
>
>
> @dberris Since I can't reproduce this, should I abandon this revision? Or would you still like the patch.


I would still like the patch, because it's still the right thing to do. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69461/new/

https://reviews.llvm.org/D69461





More information about the llvm-commits mailing list