[PATCH] D68128: [InstCombine] Fold PHIs with equal incoming pointers

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

No further comments from me.
This seems correct, but still not sure where this should actually be performed.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombinePHI.cpp:1171
+
+  Builder.SetInsertPoint(InsertPt);
+  Type *I8PtrTy = Builder.getInt8PtrTy(PhiTy->getAddressSpace());
----------------
Do you want to restore previous insertion point afterwards, i.e. use `InsertPointGuard`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68128/new/

https://reviews.llvm.org/D68128