[PATCH] D69317: Fixed a profdata file size detection on Windows system.

Sun Nov 10 07:06:38 PST 2019

mgorny added a comment.

This broke the NetBSD buildbot: http://lab.llvm.org:8014/builders/netbsd-amd64/builds/140/steps/run%20unit%20tests/logs/FAIL%3A%20LLVM%3A%3Ashow-prof-size.test

The `-o` option is not portable, and does something completely different on NetBSD:

  -o      Include the file flags in a long (-l) output.  If no file flags
          are set, “-” is displayed.  (See chflags(1) for a list of
          possible flags and their meanings.)

The same is true for at least FreeBSD and macOS. So this patch breaks more platforms than it fixes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69317/new/

https://reviews.llvm.org/D69317