[PATCH] D70034: Fix include guard and properly order __deregister_frame_info.

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 8 18:40:09 PST 2019


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

Thanks for these fixes! Personally, I'd be fine making a hard transition and making `EH_USE_FRAME_REGISTRY` independent from `CRT_HAS_INITFINI_ARRAY`, at least in our case it shouldn't cause any issue and I'd be surprised if anyone relied on the current behavior which is clearly a bug and not something I did intentionally.

Regarding the test, I think it'd be still useful to include it, but the dependency on libunwind might be a problem for actually running it, we might need to include a special check to only run that test when libunwind is being available.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70034/new/

https://reviews.llvm.org/D70034





More information about the llvm-commits mailing list