[PATCH] D70030: [MachineBlockPlacement] Update UnscheduledPredecessors when tail duplicate delete a block.

[Guozhi Wei via Phabricator via llvm-commits]

Carrot added a comment.

More interesting problem is why fillWorkLists is called with a removed BB? >From the code around of callers of fillWorkLists, we can see the removed BB is still in MachineFunction or MachineLoop data structure, we should also delete removed BB from there.



================
Comment at: llvm/lib/CodeGen/MachineBlockPlacement.cpp:2957
+  // deleted during tail duplication.
+  if (Removed)
+    for (MachineBasicBlock *Pred : DuplicatedPreds) {
----------------
Since BB is completely duplicated and removed, why not simply delete it from BlockToChain?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70030/new/

https://reviews.llvm.org/D70030