[PATCH] D70010: [OpenMP][Offloading] Replaced default stream with an actual per-device unblocking stream in NVPTX implementation

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added reviewers: ABataev, grokos, JonChesterfield.
jdoerfert added subscribers: grokos, JonChesterfield.
jdoerfert added a comment.

Can you please write a commit message explaining the change and the plan?



================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:260
+    // Destroy streams
+    for (auto &stream : Streams)
+      if (stream) {
----------------
ABataev wrote:
> tianshilei1992 wrote:
> > ABataev wrote:
> > > 1. Use real type instead of `auto`
> > > 2. Variables must start with the upper case letter.
> > Sure but just to keep align with existing code. Do I need to update existing code as well?
> In a separate patch, please
You can go either way but I would just keep it as the surrounding code for now.
Making the code blend in is arguably a good think and we have not decided how we handle the plugins in the short term (wrt. coding standard).

@JonChesterfield @grokos What do you think? Should we run once over the plugin and adjust the coding style now or keep it consistent for the time being?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70010/new/

https://reviews.llvm.org/D70010