[PATCH] D69748: [Attributor][IPConstantProp] Run the Attributor on IPConstantProp tests

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 8 12:06:54 PST 2019


jdoerfert added a comment.

In D69748#1739174 <https://reviews.llvm.org/D69748#1739174>, @efriedma wrote:

> I don't think would be a big deal to just copy the tests: if you're using the test to check the behavior of a different pass, it isn't really the same test, even if the IR is identical.


I'm fine with that but I'd prefer to invest the time only if I have confidence I get it in then.
@fhahn, @davide Is this OK with you or would you object?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69748/new/

https://reviews.llvm.org/D69748





More information about the llvm-commits mailing list