[PATCH] D70020: [lld] Better support for group semantic wrt. notes

[serge via Phabricator via llvm-commits]

serge-sans-paille created this revision.
serge-sans-paille added reviewers: psmith, ruiu.
serge-sans-paille added a project: lld.
Herald added subscribers: llvm-commits, MaskRay, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
serge-sans-paille added a comment.

I stll need to do some extra validation, but the patch is in a decent state and I'll happily take feedbakc. @psmith I followed the discussion we had at FOSDEM back in Februrary and limited the scope of the patch to SHT_NOTE.


When a note is in a group and the other elements of the group are discarded, also discard the note. This is needed both to respect the group semantic and for the annobin tool (see https://developers.redhat.com/blog/2018/02/20/annobin-storing-information-binaries/).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70020

Files:
  lld/ELF/InputFiles.cpp
  lld/ELF/MarkLive.cpp
  lld/test/ELF/sht-group-note.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70020.228493.patch
Type: text/x-patch
Size: 5051 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191108/e0fbcf38/attachment.bin>