[PATCH] D70010: [OpenMP][Offloading] Replaced default stream with an actual per-device unblocking stream in NVPTX implementation

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added a comment.

Also, the main question, how does it affect the exiting execution model? What if we have target region in a parallel region, will they be executed asynchronously? We need some tests for this if we don't have such tests.



================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:260
+    // Destroy streams
+    for (auto &stream : Streams)
+      if (stream) {
----------------
tianshilei1992 wrote:
> ABataev wrote:
> > 1. Use real type instead of `auto`
> > 2. Variables must start with the upper case letter.
> Sure but just to keep align with existing code. Do I need to update existing code as well?
In a separate patch, please


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70010/new/

https://reviews.llvm.org/D70010