[PATCH] D69997: [llvm-objdump] Print relocation addends in hexadecimal

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objdump/ELFDump.cpp:113
+      if (Addend < 0)
+        Addend = -Addend;
+
----------------
davidb wrote:
> jhenderson wrote:
> > davidb wrote:
> > > jhenderson wrote:
> > > > Won't this fail for minimum int64_t?
> > > Yes. Is there a better abs implementation or function in LLVM that works around this case?
> > I'm not aware of one, unfortunately, but do you need it?
> > 
> > My reading of the code is that format(AddendFmt, Addend) combined with the PRIx64 (which uses a signed integer type) you used above should be sufficient.
> Yes, I need the absolute value for the string representation so `foo-0x4` rather than `foo+0xfffffffc`....
Right, of course, sorry.

The answer to [[ https://stackoverflow.com/questions/17313579/is-there-a-safe-way-to-get-the-unsigned-absolute-value-of-a-signed-integer-with | this stack overflow post ]] suggests the way to do it is to cast the type to the unsigned equivalent and then negating it (rather than the other way around). I haven't tested that this works though. You should add a test case for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69997/new/

https://reviews.llvm.org/D69997