[PATCH] D69462: [DebugInfo]: Support for debug_loclists.dwo section in llvm and llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked an inline comment as done.
SouraVX added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1195
 
-  if (useSplitDwarf())
+  if (useSplitDwarf() && getDwarfVersion() <= 4)
+    // Handles only debug_loc.dwo section emission
----------------
SouraVX wrote:
> In current implementation, `emitDebugLocDWO()` only handles `-gdwarf-4 -gsplit-dwarf` case.
> Rest of the cases
> `-gdwarf-4`, `-gdwarf-5`, `-gdwarf-5 -gsplit-dwarf` are handled by emitDebugLoc();.
> 
> 
> 
> 
> 
> 
I also have another implementation, which keeps above code uniform as in
  if (useSplitDwarf())
    emitDebugLocDWO();
  else
    emitDebugLoc(); 
But bloat's up a little `emitDebugLocDWO()` function.  This is a bit cleaner but with one extra check in if.
Please share, your views on this and overall patch, and I shall incorporate changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69462/new/

https://reviews.llvm.org/D69462