[PATCH] D69889: [DebugInfo] Avoid creating entry values for clobbered registers

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1281
+bool LiveDebugValues::isEntryValueCandidate(const MachineInstr &MI,
+                                            DefinedRegsSet &DefinedRegs) const {
   if (!MI.isDebugValue())
----------------
`const DefinedRegsSet&`?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1370
 
+  DefinedRegsSet DefinedRegs;
+
----------------
Perhaps we can add a comment here describing what is the purpose of adding this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69889/new/

https://reviews.llvm.org/D69889