[PATCH] D69997: [llvm-objdump] Print relocation addends in hexadecimal
    Dave Bozier via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Nov  8 03:13:32 PST 2019
    
    
  
davidb marked an inline comment as done.
davidb added inline comments.
================
Comment at: llvm/tools/llvm-objdump/ELFDump.cpp:113
+      if (Addend < 0)
+        Addend = -Addend;
+
----------------
jhenderson wrote:
> Won't this fail for minimum int64_t?
Yes. Is there a better abs implementation or function in LLVM that works around this case?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69997/new/
https://reviews.llvm.org/D69997
    
    
More information about the llvm-commits
mailing list