[PATCH] D69592: [ELF] Suggest extern "C" when an undefined reference is mangled while the definition is not

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 8 02:37:12 PST 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/Relocations.cpp:773
+        if (s) {
+          pre_hint = ": extern \"C\" ";
+          return s;
----------------
pre_hint -> preHint (but can be just `hint`?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69592/new/

https://reviews.llvm.org/D69592





More information about the llvm-commits mailing list