[PATCH] D69997: Print relocation addends in hexadecimal
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 8 02:25:08 PST 2019
grimar added a comment.
Seems that printing relocations in hex is reasonable (though I'd like to hear from others too).
You need to change the title to include a tool name. Look at the recent commits for llvm-objdump.
Did you run LLD tests (I'd expect them to fail)?
================
Comment at: llvm/tools/llvm-objdump/ELFDump.cpp:115
+
+ Fmt << Sign << format(AddendFmt, Addend);
+ }
----------------
Will the following work?
```
if (Addend != 0)
Fmt << Sign << format("0x%" PRIx64, abs(Addend));
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69997/new/
https://reviews.llvm.org/D69997
More information about the llvm-commits
mailing list