[lld] f95273f - Keep symbols passed by -init and -fini

[Rui Ueyama via llvm-commits]

Author: Rui Ueyama
Date: 2019-11-08T19:08:15+09:00
New Revision: f95273f75aaa5db5493aea7902416ce3d5a09043

URL: https://github.com/llvm/llvm-project/commit/f95273f75aaa5db5493aea7902416ce3d5a09043
DIFF: https://github.com/llvm/llvm-project/commit/f95273f75aaa5db5493aea7902416ce3d5a09043.diff

LOG: Keep symbols passed by -init and -fini

Previously, symbols passed by -init and -fini look as if they are
not referenced by anyone, and the LTO might eliminate them.
This patch fixes the issue.

Fixes a bug reported in https://bugs.llvm.org/show_bug.cgi?id=43927

Differential Revision: https://reviews.llvm.org/D69985

Added: 
    lld/test/ELF/lto/init-fini.ll

Modified: 
    lld/ELF/Driver.cpp

Removed: 
    


################################################################################
diff  --git a/lld/ELF/Driver.cpp b/lld/ELF/Driver.cpp
index 1b1a50bf6d1c..616a9d4c4e8a 100644
--- a/lld/ELF/Driver.cpp
+++ b/lld/ELF/Driver.cpp
@@ -1782,6 +1782,12 @@ template <class ELFT> void LinkerDriver::link(opt::InputArgList &args) {
   for (StringRef pat : args::getStrings(args, OPT_undefined_glob))
     handleUndefinedGlob(pat);
 
+  // Mark -init and -fini symbols so that the LTO doesn't eliminate them.
+  if (Symbol *sym = symtab->find(config->init))
+    sym->isUsedInRegularObj = true;
+  if (Symbol *sym = symtab->find(config->fini))
+    sym->isUsedInRegularObj = true;
+
   // If any of our inputs are bitcode files, the LTO code generator may create
   // references to certain library functions that might not be explicit in the
   // bitcode file's symbol table. If any of those library functions are defined

diff  --git a/lld/test/ELF/lto/init-fini.ll b/lld/test/ELF/lto/init-fini.ll
new file mode 100644
index 000000000000..cf466e5a60f3
--- /dev/null
+++ b/lld/test/ELF/lto/init-fini.ll
@@ -0,0 +1,38 @@
+; REQUIRES: x86
+; RUN: llvm-as %s -o %t.o
+
+;;
+;; Verify that symbols given by -init and -fini are preserved and
+;; DT_INIT/DT_FINI are created.
+;;
+
+; RUN: ld.lld -o %t.exe -pie %t.o
+; RUN: llvm-nm %t.exe | FileCheck -check-prefix=TEST1 --allow-empty %s
+; RUN: llvm-readelf -d %t.exe | FileCheck -check-prefix=TEST2 %s
+
+; TEST1-NOT: foo
+; TEST1-NOT: bar
+
+; TEST2-NOT: INIT
+; TEST2-NOT: FINI
+
+; RUN: ld.lld -o %t.exe -pie -init=foo -fini=bar %t.o
+; RUN: llvm-nm %t.exe | FileCheck -check-prefix=TEST3 %s
+; RUN: llvm-readelf -d %t.exe | FileCheck -check-prefix=TEST4 %s
+
+; TEST3: bar
+; TEST3: foo
+
+; TEST4: INIT
+; TEST4: FINI
+
+target triple = "x86_64-unknown-linux-gnu"
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+
+define void @foo() {
+  ret void
+}
+
+define void @bar() {
+  ret void
+}