[PATCH] D69993: [APInt] Add saturating truncation methods
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 8 01:27:35 PST 2019
lebedev.ri added a comment.
In D69993#1738340 <https://reviews.llvm.org/D69993#1738340>, @nikic wrote:
> LGTM
>
> I feel like the names are a bit inconsistent with existing uadd_sat etc, but utrunc_sat seems worse than truncUSat, so let's just go with it...
Yes, i'm on the fence regarding names here.
I initially used `trunc{Unsigned,Sign/Signed}Sat()`, but that didn't seem much better..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69993/new/
https://reviews.llvm.org/D69993
More information about the llvm-commits
mailing list